fix: always allow localhost to connect to dev server#5456
Closed
stephenwade wants to merge 3 commits intowebpack:masterfrom
Closed
fix: always allow localhost to connect to dev server#5456stephenwade wants to merge 3 commits intowebpack:masterfrom
stephenwade wants to merge 3 commits intowebpack:masterfrom
Conversation
stephenwade
requested review from
alexander-akait,
anshumanv,
hiroppy and
snitin315
as code owners
|
|
||
| expect(server.isSameOrigin(headers)).toBe(false); | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Please write test in e2e directory, no need unit tests
Author
There was a problem hiding this comment.
I'm not sure how to write an e2e test that exhibits the issue. Can you guide me?
Member
There was a problem hiding this comment.
Please take a look at e2e directory, we have a lot of e2e tests there
Member
|
Fixed in main, we can't allow any localhost connections, because attacker site (for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
The security changes in v5.2.1 broke webpack-dev-server for subdomains of localhost (e.g. http://myproject.localhost:8000). This PR fixes the changes and adds a test verifying that the behavior has changed.
Breaking Changes
N/A
Additional Info
I also tested this change by patching my project's copy of webpack-dev-server and it works as expected.